Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] issue fixed #20304 No space between step title and saved address in c… #20418

Merged
merged 1 commit into from
Jan 31, 2019
Merged

[Backport] issue fixed #20304 No space between step title and saved address in c… #20418

merged 1 commit into from
Jan 31, 2019

Conversation

shikhamis11
Copy link
Member

Original Pull Request

#20306
…heckout

issue fixed #20304 No space between step title and saved address in checkout

Manual testing scenarios (*)

Step 1: Open frontend
Step 2: Add any product in cart
Step 3: Go to checkout and login as existing customer

Note: Address should saved already

Step 4: Goto checkout in step 1(Shipping adress)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@cedarvinda
issue fixed #20304 No space between step title and saved address in c…
16d7461 
…heckout

issue fixed #20304 No space between step title and saved address in checkout
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4010 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 31, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 16d7461 into magento:2.2-develop Jan 31, 2019
@ghost
Copy link

ghost commented Jan 31, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 31, 2019
@sidolov
ENGCOM-4010: [Backport] issue fixed #20304 No space between step titl…
d0e3007 
…e and saved address in c… #20418
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@sidolov sidolov

Labels
Area: Design/Frontend Community Insider: Cedcommerce community-insider-contribution Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@shikhamis11 @magento-engcom-team @sidolov @okorshenko @cedarvinda